Place unknown artists last when sorting by artist #42
+63
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
karenska
deleted the
41-place-unknown-artists-last-when-sorting-by-artist
branch
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place artworks with missing, empty, whitespace-only or “Unknown” artist names last in both artist sorting directions. Sorting happens before pagination and retains ID as a tie-breaker. Title sorting and default ordering remain unchanged.
Added API tests for unknown artists across all pages in both directions. All 28 API tests, linting and TypeScript checks pass.
Closes #41